Re: review: FDW API - Mailing list pgsql-hackers

From Tom Lane
Subject Re: review: FDW API
Date
Msg-id 28279.1297797214@sss.pgh.pa.us
Whole thread Raw
In response to Re: review: FDW API  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: review: FDW API  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> As the patch stands, we have to do get_rel_relkind() in a couple of 
> places in parse analysis and the planner to distinguish a foreign table 
> from a regular one. As the patch stands, there's nothing in 
> RangeTblEntry (which is what we have in transformLockingClause) or 
> RelOptInfo (for set_plain_rel_pathlist) to directly distinguish them.

Hmm.  I don't have a problem with adding relkind to the planner's
RelOptInfo, but it seems to me that if parse analysis needs to know
this, you have put functionality into parse analysis that does not
belong there.

(No, I haven't read the patch...)
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: review: FDW API
Next
From: Peter Eisentraut
Date:
Subject: Re: pl/python do not delete function arguments