Re: pg_control read error message - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_control read error message
Date
Msg-id 28273.1526653349@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_control read error message  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: pg_control read error message  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 18/05/18 14:32, Magnus Hagander wrote:
>> If pg_control is for some reason empty, we give an error messagfe like:
>> 2018-05-18 13:24:03.342 CEST [19697] PANIC:  could not read from control
>> file: Success
>> Which is, uh, wrong -- it's definitely not successful.
>> Obviously this is a state where the user is fairly screwed anyway, but we
>> should give a better message.
>> Attached is a patch that does this. Reasonable?

> Looks good to me.

Only comment I have is that I think there's similar shortcuts in a lot
of places :-(

            regards, tom lane


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Use access() to check file existence inGetNewRelFileNode().
Next
From: Tom Lane
Date:
Subject: Re: Postgres 11 release notes