Re: REPACK enhancements - Mailing list pgsql-hackers

From Antonin Houska
Subject Re: REPACK enhancements
Date
Msg-id 28204.1790879346@localhost
Whole thread
In response to Re: REPACK enhancements  (shihao zhong <zhong950419@gmail.com>)
List pgsql-hackers
shihao zhong <zhong950419@gmail.com> wrote:

> The compute_new_xmax_infomask() Assert is easy to hit. The
> AccessExclusiveLock in rebuild_relation_finish_concurrent() assigns an
> XID, so any UPDATE or DELETE committed while REPACK waits for it fails
> on replay. The attached spec does it every time.

Ah, I see, the assertion itself is wrong. Thanks.

> If you give the new counter a slot that index builds don't write,
> like 13, 0008 does not have to depend on 6958.

It'd work, but if [1] gets merged, this workaround would be confusing.

[1] https://commitfest.postgresql.org/patch/6958/

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com



pgsql-hackers by date:

Previous
From: Rustam ALLAKOV
Date:
Subject: Re: Fold NOT IN / <> ALL expressions containing NULL to FALSE
Next
From: Masahiko Sawada
Date:
Subject: Re: REPACK (CONCURRENTLY) can crash a logical decoding session