Re: pgsql: Improve error handling in RemovePgTempFiles(). - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Improve error handling in RemovePgTempFiles().
Date
Msg-id 28071.1515375705@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Improve error handling in RemovePgTempFiles().  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Improve error handling in RemovePgTempFiles().
List pgsql-committers
I wrote:
> Hmmm ... actually, in the recursive call case, it wouldn't be that
> awful to ignore ENOENT either; if a directory goes away between being
> stat'd and being opened, you'd still get a log message about rmdir
> failure at the caller level.  So maybe we should just do your
> second alternative as-is (ie, code as above but without missing_ok).
> Having an explicit control parameter seems marginally clearer but
> I'm not sure it's buying anything meaningful.  Thoughts?

Hearing no comments, I did it the first way.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Back off chattiness in RemovePgTempFiles().
Next
From: Thomas Munro
Date:
Subject: Re: pgsql: Improve error handling in RemovePgTempFiles().