pgstattuple: Have pgstattuple_approx accept TOAST tables - Mailing list pgsql-hackers

From Peter Eisentraut
Subject pgstattuple: Have pgstattuple_approx accept TOAST tables
Date
Msg-id 27c4496a-02b9-dc87-8f6f-bddbef54e0fe@2ndquadrant.com
Whole thread Raw
Responses Re: pgstattuple: Have pgstattuple_approx accept TOAST tables
List pgsql-hackers
I alluded to this in [0], but it's better discussed in its own thread.

I think the check that makes pgstattuple_approx reject TOAST tables is a 
mistake.  They have visibility and free space map, and it works just 
fine if the check is removed.

Attached is a patch to fix this and add some tests related to how 
pgstattuple and pg_visibility accept TOAST tables for inspection.


[0]: 
https://www.postgresql.org/message-id/dc35a398-37d0-75ce-07ea-1dd71d98f8ec@2ndquadrant.com

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: Support for DATETIMEOFFSET
Next
From: Prabhat Sahu
Date:
Subject: Re: [Proposal] Global temporary tables