Re: installdir patch for win32 - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: installdir patch for win32
Date
Msg-id 2784.24.211.141.25.1080269132.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: installdir patch for win32  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane said:
>
> I'm not expecting to see zero ifdefs --- certainly not in the port
> modules ;-).  But Bruce's search, further up in the thread, showed that
> #ifdef WIN32's are sneaking into a lot of modules that probably
> shouldn't have any platform dependencies.  I don't think that's a good
> sign.  We should be working to keep those dependencies localized.
>

I think it's a chicken and egg argument. Now that we are getting close we
have a better idea of what needs to be wrapped in port-specific modules
etc. (Bruce's count was slightly over - I ran a slightly more restrictive
search and found 193 occurences of #ifdef WIN32 and friends.)

I'll revisit some of my contributed code and see what can be eliminated.

cheers

andrew



pgsql-patches by date:

Previous
From: Claudio Natoli
Date:
Subject: Re: APC/socket fix (final?)
Next
From: Alvaro Herrera
Date:
Subject: Re: installdir patch for win32