Re: Add -k/--link option to pg_combinebackup - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add -k/--link option to pg_combinebackup
Date
Msg-id 278129.1742330293@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add -k/--link option to pg_combinebackup  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Add -k/--link option to pg_combinebackup
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Mar 18, 2025 at 1:55 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> 10s added to every check-world run doesn't sound "cheap" to me.

> Really? If you're sensitive to the time the tests take to run, maybe
> use 'meson test' rather than 'make check-world'?

FTR, what I actually use is

make -s -j10 check-world >/dev/null

which I like because I don't see any output unless there's a problem.
On my machine, that took right about 2 minutes for a long time;
lately it's crept up to about 2:15 which is already annoying me.
Admittedly an additional 10-second test might not add much to that
due to parallelism, but then again it might; it's hard to tell how
much slop we have in the parallel scheduling.

Anyway, I'm totally fine with finding a way to allow pgindent
checking to be included, as long as I can opt out of that.
I don't especially want to see buildfarm cycles going into it
on every animal, either.  If there's any test we have that ought
to be completely deterministic, it'd be this one.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Increase default maintenance_io_concurrency to 16
Next
From: "David G. Johnston"
Date:
Subject: Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.