Re: stats test on Windows is now failing repeatably? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: stats test on Windows is now failing repeatably?
Date
Msg-id 27752.1156950619@sss.pgh.pa.us
Whole thread Raw
In response to stats test on Windows is now failing repeatably?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: stats test on Windows is now failing repeatably?
List pgsql-hackers
"Magnus Hagander" <mha@sollentuna.net> writes:
>> It looks to me like we have implemented Windows' FILE_SHARE_DELETE
>> flag for open() calls but not for fopen().  Isn't this a problem?
>> We do use fopen() for stuff like pgstat.stat.

> That definitely sounds like a problem, there is no reason why the issue
> shouldn't occur for fopen(). Do you want to work up a patch for that
> based on open(), or do you want me to take a look at it?

It looks straightforward to apply our reimplemented pgwin32_open()
followed by fdopen(), but since I don't have a Windows build environment
I couldn't test the patch.  Please take a look at it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: Autovacuum on by default?
Next
From: "Jim C. Nasby"
Date:
Subject: Re: TODO Request