Re: New warning in pg_dump - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New warning in pg_dump
Date
Msg-id 27748.1093319552@sss.pgh.pa.us
Whole thread Raw
In response to Re: New warning in pg_dump  (Philip Warner <pjw@rhyme.com.au>)
List pgsql-hackers
Philip Warner <pjw@rhyme.com.au> writes:
> At 01:27 PM 24/08/2004, Tom Lane wrote:
>> I prefer declaring it as unsigned, which means you drop the
>> \377 end instead ...

> ...I've used explicit values (128) since '\200' is -127.

Actually I'd go with "(unsigned char) '\200'".  There's a bunch
of different possible viewpoints here of course, but given that
you are trying to mimic a backend flex file that speaks of \200-\377,
I'd opt for something that's clearly traceable to that form.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: auto-casting a bit more intelligent in 8.0 ... ?
Next
From: Christopher Kings-Lynne
Date:
Subject: Re: [COMMITTERS] pgsql-server: Rearrange pg_subtrans handling