Re: remove ATTRIBUTE_FIXED_PART_SIZE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: remove ATTRIBUTE_FIXED_PART_SIZE
Date
Msg-id 27705.1534617420@sss.pgh.pa.us
Whole thread Raw
In response to remove ATTRIBUTE_FIXED_PART_SIZE  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: remove ATTRIBUTE_FIXED_PART_SIZE
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Since the introduction of the CATALOG_VARLEN stuff, the fixed size of
> pg_attribute is exactly sizeof(FormData_pg_attribute), so the ancient
> mechanism to track the fixed size manually using
> ATTRIBUTE_FIXED_PART_SIZE can be removed.

Meh, I'm not sure about this.  What about the possibility of trailing
padding after the last fixed column, as the comment you propose to
remove is talking about?  Sure, we don't have that today, but we
might again the next time somebody adds a column to pg_attribute.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: remove ATTRIBUTE_FIXED_PART_SIZE
Next
From: Peter Eisentraut
Date:
Subject: Re: Fix hints on CREATE PROCEDURE errors