Re: bufmgr: pass through I/O stats context in FlushUnlockedBuffer() - Mailing list pgsql-hackers

> On Apr 22, 2026, at 05:52, Melanie Plageman <melanieplageman@gmail.com> wrote:
>
> On Tue, Mar 31, 2026 at 10:15 PM Chao Li <li.evan.chao@gmail.com> wrote:
>>
>> I noticed that FlushUnlockedBuffer() accepts io_object and io_context, but then ignores them and hardcodes
IOOBJECT_RELATIONandIOCONTEXT_NORMAL instead: 
>> ```
>> static void
>> FlushUnlockedBuffer(BufferDesc *buf, SMgrRelation reln,
>>                                        IOObject io_object, IOContext io_context)
>> {
>>        Buffer          buffer = BufferDescriptorGetBuffer(buf);
>>
>>        BufferLockAcquire(buffer, buf, BUFFER_LOCK_SHARE_EXCLUSIVE);
>>        FlushBuffer(buf, reln, IOOBJECT_RELATION, IOCONTEXT_NORMAL); // <== HERE
>>        BufferLockUnlock(buffer, buf);
>> }
>> ```
>>
>> Unless I am missing something, if a function accepts these parameters, they should generally be used.
>
> Thanks for the patch. Committed in 31b0544b32b
>
> - Melanie

Hi Melanie, thank you very much for pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/