Re: New warning in pg_dump - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New warning in pg_dump
Date
Msg-id 27487.1093318068@sss.pgh.pa.us
Whole thread Raw
In response to Re: New warning in pg_dump  (Philip Warner <pjw@rhyme.com.au>)
Responses Re: New warning in pg_dump  (Philip Warner <pjw@rhyme.com.au>)
List pgsql-hackers
Philip Warner <pjw@rhyme.com.au> writes:
> At 01:58 AM 24/08/2004, Alvaro Herrera wrote:
>> static int _isIdentChar(unsigned char c)

> I think the correct thing to do is to leave it as (signed) char, and remove 
> the comparison to \200 = -127.

No, that isn't the right thing, because not all platforms think char is
signed.  I prefer declaring it as unsigned, which means you drop the
\377 end instead ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Philip Warner
Date:
Subject: Re: New warning in pg_dump
Next
From: Philip Warner
Date:
Subject: Re: New warning in pg_dump