Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] lock_timeout and common SIGALRM framework - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] lock_timeout and common SIGALRM framework
Date
Msg-id 27465.1342218211@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] lock_timeout and common SIGALRM framework  (Boszormenyi Zoltan <zb@cybertec.at>)
Responses Re: [PATCH] lock_timeout and common SIGALRM framework  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Tree view 
Boszormenyi Zoltan <zb@cybertec.at> writes:
>>> Try SET deadlock_timeout = 0;

Actually, when I try that I get

ERROR:  0 is outside the valid range for parameter "deadlock_timeout" (1 .. 2147483647)

So I don't see any bug here.  The places that are unconditionally doing
"enable_timeout_after(..., DeadlockTimeout);" are perfectly fine.  The
only place that might need an if-test has already got one:
         if (StatementTimeout > 0)
!             enable_timeout_after(STATEMENT_TIMEOUT, StatementTimeout);         else
!             disable_timeout(STATEMENT_TIMEOUT, false);

        regards, tom lane

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] lock_timeout and common SIGALRM framework
Next
From: Alvaro Herrera
Date:
Subject: Re: isolation check takes a long time