Re: pg_dump and inherited attributes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump and inherited attributes
Date
Msg-id 27371.1032926484@sss.pgh.pa.us
Whole thread Raw
In response to pg_dump and inherited attributes  (Alvaro Herrera <alvherre@atentus.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@atentus.com> writes:
> I'm looking at pg_dump/common.c:flagInhAttrs() and suspect that it can
> be more or less rewritten completely, and probably should to get rigth
> all the cases mentioned in the past attisinherited discussion.  Is this
> desirable for 7.3?  It can probably be hacked around and the rewrite
> kept for 7.4, but I think it will be much simpler after the rewrite.

If it's a bug then it's fair game to fix in 7.3.  But keep in mind that
pg_dump has to behave at least somewhat sanely when called against older
servers ... will your rewrite behave reasonably if the server does not
offer attinhcount values?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: contrib/earthdistance missing regression test files
Next
From: Tom Lane
Date:
Subject: Re: making use of large TLB pages