Re: [PATCH] ruleutils: Fix subqueries with shadowed aliases - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] ruleutils: Fix subqueries with shadowed aliases
Date
Msg-id 27275.1560383173@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] ruleutils: Fix subqueries with shadowed aliases  (Philip Dubé <Philip.Dub@microsoft.com>)
List pgsql-hackers
=?iso-8859-1?Q?Philip_Dub=E9?= <Philip.Dub@microsoft.com> writes:
> Discovered while looking into issue here: https://github.com/citusdata/citus/pull/2733
> For completeness I'll quote the example code to demonstrate the issue:
> ...
> Where the 2nd join_alias should be renamed to join_alias_1

Good catch!  The proposed test case is less good though, because
it doesn't actually exercise the bug, ie the test case passes
with or without the code change.  (You also stuck it into the
middle of a bunch of not-very-related test cases.)  I adapted
your example into a better test case and pushed it.  Thanks
for the report and fix.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Should we warn against using too many partitions?
Next
From: Tomas Vondra
Date:
Subject: Re: Adaptive query optimization