Postgres Pro
Downloads
Home   >   mailing lists

Re: Converting tab-complete.c's else-if chain to a switch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Converting tab-complete.c's else-if chain to a switch
Date
Msg-id 2726082.1728594286@sss.pgh.pa.us
Whole thread Raw
In response to Converting tab-complete.c's else-if chain to a switch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
Jacob Champion <jacob.champion@enterprisedb.com> writes:
> Meson's coverage generation is unhappy with the new hardcoded #line
> references emitted by gen_tabcomplete.pl:
>     genhtml: ERROR: cannot read
> /home/jacob/src/postgres/worktree-oauth/build-dev/tab-complete.in.c
> I've attached a potential fix which references $ARGV[0] instead, but
> it's not really tested beyond "works for me".

I tried this with meson and with a VPATH configure build, and it
seemed to work all right for both.  (The coverage report in a
VPATH configure build is kind of wonky, but that was true before,
and I'm not sure that anyone wants to put effort into making it
cleaner.)  Pushed.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: sunsetting md5 password support
Next
From: Mikael Sand
Date:
Subject: Re: Build issue with postgresql 17 undefined reference to `pg_encoding_to_char' and `pg_char_to_encoding'