Re: pgsql: Get rid of SET LOGGED indexes persistence kludge - Mailing list pgsql-committers

Tom Lane <tgl@sss.pgh.pa.us> writes:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> Get rid of SET LOGGED indexes persistence kludge

> The buildfarm suggests that this patch fails under CLOBBER_CACHE_ALWAYS.

After a bit of study, the explanation is almost certainly that you can't
just do this in reindex_index:

+       /* Set the relpersistence of the new index */
+       iRel->rd_rel->relpersistence = persistence;

Probably the right fix is to add a persistence parameter to
RelationSetNewRelfilenode.  The existing patch seems pretty
klugy without that anyway.

            regards, tom lane