Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function - Mailing list pgsql-rrreviewers

From Tom Lane
Subject Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function
Date
Msg-id 27165.1281295097@sss.pgh.pa.us
Whole thread Raw
In response to Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function  (Mike Fowler <mike@mlfowler.com>)
List pgsql-rrreviewers
Mike Fowler <mike@mlfowler.com> writes:
> On 06/08/10 20:55, Peter Eisentraut wrote:
>> On fre, 2010-08-06 at 09:04 +0100, Mike Fowler wrote:
>>> If the patch is to be committed, does it make sense for me to refine
>>> it such that it uses the new xpath internal function you extracted in
>>> the xmlexists patch?
>>
>> Yes, you can probably shrink this patch down to about 20 lines.

> Updated the patch so that it will apply to head and re-worked the
> function to use the new xpath internal function.

Applied with minor corrections (improved docs, fixed regression tests,
adjusted OIDs for CVS HEAD).

            regards, tom lane

pgsql-rrreviewers by date:

Previous
From: Mike Fowler
Date:
Subject: Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function
Next
From: "Kevin Grittner"
Date:
Subject: CommitFest 2010-07 week four progress report