Re: Support isEmptyStringInfo - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Support isEmptyStringInfo
Date
Msg-id 2706195.1648044823@sss.pgh.pa.us
Whole thread Raw
In response to Re: Support isEmptyStringInfo  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Support isEmptyStringInfo  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> I think that the code is perfectly readable as it is and that this
> change makes it less so.

Yeah, after a quick look through this patch I'm unimpressed too.
The new code is strictly longer, and it requires the introduction
of distracting "!" and "&" operators in many places.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: clean up test_rls_hooks module
Next
From: Simon Riggs
Date:
Subject: Re: Parameter for planner estimate of recursive queries