Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 5/19/19 12:09 PM, Tom Lane wrote:
>> Given the current unpleasantness, I think it's quite important that
>> we fix 004_logrotate.pl so that it (a) poses an end-to-end test
>> and (b) works on Windows. I think (a) could be managed by having
>> the test execute guaranteed-to-fail SQL commands ("select 1/0" or
>> the like) and making it look into the log file to verify that the
>> expected error messages appear there. (b) is a little harder in
>> view of Andrew's point that we can't just summarily rename or unlink
>> the log file. But I don't much like using a fixed log file name
>> in the test anyway. I propose that we let it use the default logfile
>> pattern (postgresql-%Y-%m-%d_%H%M%S.log), and that we just sleep for a
>> couple of seconds before requesting rotation, and that we verify that
>> the file name actually changed. We can avoid difficult issues of
>> guessing what file name got used by having the test script look into
>> "current_logfiles" to get the name --- which is another feature that
>> there's exactly zero test coverage of right now, so that seems like
>> a win all around.
> Worth a try.
Done. I went ahead and pushed it, but if the buildfarm shows any
sign of unhappiness I'll just revert it.
regards, tom lane
