Re: TODO items for window functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: TODO items for window functions
Date
Msg-id 26955.1230739481@sss.pgh.pa.us
Whole thread Raw
In response to Re: TODO items for window functions  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: TODO items for window functions  (David Fetter <david@fetter.org>)
Re: TODO items for window functions  (Dimitri Fontaine <dfontaine@hi-media.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Heikki Linnakangas escribi�:
>> Tom Lane wrote:
>>> pg_catalog | nth_value | anyelement       | anyelement, integer OVER window
>> 
>> That looks like "OVER window" is associated with the "integer", like  
>> DEFAULT. I don't have any better suggestions, though.

>   pg_catalog | nth_value | anyelement       | (anyelement, integer) OVER window

Yeah, I had considered that too, and it has a distinct advantage for
parameterless functions like rank():
  Schema   | Name | Result data type | Argument data types 
------------+------+------------------+---------------------pg_catalog | rank | bigint           | OVER
windowpg_catalog| rank | bigint           | () OVER window
 

The latter is definitely clearer about what you're supposed to do.

However, it seems kind of inconsistent to do this for window functions
unless we also make \df start putting parens around the argument lists
for regular functions.  Comments?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_pltemplate entries for external PLs
Next
From: Bruce Momjian
Date:
Subject: Re: version() output vs. 32/64 bits