Re: pgsql-server/src/interfaces/libpq Makefile - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server/src/interfaces/libpq Makefile
Date
Msg-id 26881.1050982758@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql-server/src/interfaces/libpq Makefile  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-committers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> Why?  libpq doesn't use rename, and I don't think it should be using

> Also, keep in mind that it will effect other clients who do use
> rename/unlink.  The question is whether they assume Unix semantics on
> those commands.  I don't know the answer, but I assumed they did.

I don't believe any of our standard clients care, and in any case libpq
is not the place to put it if they do.

>> unlink (someone *please* tell me that that unlink in getaddrinfo_unix
>> is a brain-dead error...)

> Not sure --- that's why I added it.

Even if it's correct (which I doubt) it's inside #ifdef
HAVE_UNIX_SOCKETS and therefore irrelevant to Windows.

            regards, tom lane


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql-server/src/interfaces/libpq Makefile
Next
From: Tom Lane
Date:
Subject: Re: pgsql-server/src/interfaces/libpq Makefile