Re: improvements for dict_xsyn extended synonym dictionary - RRR - Mailing list pgsql-hackers

From Tom Lane
Subject Re: improvements for dict_xsyn extended synonym dictionary - RRR
Date
Msg-id 2688.1248984206@sss.pgh.pa.us
Whole thread Raw
In response to Re: improvements for dict_xsyn extended synonym dictionary - RRR  (karpov@sao.ru (Sergey V. Karpov))
Responses Re: improvements for dict_xsyn extended synonym dictionary - RRR
List pgsql-hackers
karpov@sao.ru (Sergey V. Karpov) writes:
> Andres Freund <andres@anarazel.de> writes:
>> Looks nice. The only small gripe I have is that the patch adds trailing
>> whitespaces at a lot of places...

> My fault. Please check the patch version attached - I've tried to fix
> all those.

I did some minor cleanup on this patch:
    * make the two parsing loops less confusingly different
    * remove unused 'pos' field of Syn
    * avoid some unnecessary pallocs
    * improve the comments and docs a bit

I think it's "ready for committer" too, but the committer I have in mind
is Teodor --- he's the ultimate expert on tsearch stuff.  Teodor, have
you got time to look this over and commit it?

            regards, tom lane


Attachment

pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Review: Revise parallel pg_restore's scheduling heuristic
Next
From: Steve Prentice
Date:
Subject: PATCH: make plpgsql IN args mutable (v1)