Re: [PATCH] Alter or rename enum value - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Alter or rename enum value
Date
Msg-id 26875.1472935684@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Alter or rename enum value  (Emre Hasegeli <emre@hasegeli.com>)
Responses Re: [PATCH] Alter or rename enum value  (Emre Hasegeli <emre@hasegeli.com>)
List pgsql-hackers
Emre Hasegeli <emre@hasegeli.com> writes:
> Other than these, it looks good to me.  I am marking it as Ready for Committer.

I started looking at this patch.  I'm kind of unhappy with having *both*
IF EXISTS and IF NOT EXISTS options on the statement, especially since
the locations of those phrases in the syntax seem to have been chosen
with a dartboard.  This feels way more confusing than it is useful.
Is there really a strong use-case for either option?  I note that
ALTER TABLE RENAME COLUMN, which is probably used a thousand times
more often than this will be, has so far not grown either kind of option,
which sure makes me think that this proposal is getting ahead of itself.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: \timing interval
Next
From: Vik Fearing
Date:
Subject: Long options for pg_ctl waiting