Re: lots of unused variable warnings in assert-free builds - Mailing list pgsql-hackers

From Tom Lane
Subject Re: lots of unused variable warnings in assert-free builds
Date
Msg-id 26814.1326914463@sss.pgh.pa.us
Whole thread Raw
In response to Re: lots of unused variable warnings in assert-free builds  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> On sön, 2012-01-15 at 01:37 -0500, Tom Lane wrote:
>> Surely this will fail entirely on most non-gcc compilers?

> No, because __attribute__() is defined to empty for other compilers.  We
> use this pattern already.

Oh, duh.  In that case my only objection to doing it like this is that
I'd like to see what pgindent will do with it.  pgindent is not very
nice about #ifdef's in variable lists (it tends to insert unwanted
vertical space) so it's possible that this way will look better.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Command Triggers
Next
From: Peter Eisentraut
Date:
Subject: Re: return values of backend sub-main functions