Re: [HACKERS] pg_dump --comment? - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] pg_dump --comment?
Date
Msg-id 26695.1086356633@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] pg_dump --comment?  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] pg_dump --comment?  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> What happens in a pg_dump -Fc / pg_restore scenario?

> So, in non-ascii format, I need to dump a comment record and read it
> back on restore?  Yuck.  Anyone want to tackle that?

Yes.  Hacking the output routines alone is almost never the right way
to do things in pg_dump.

My feeling is that if anyone cares to tackle this, it would be
appropriate to add a record type that carries a user-supplied
comment, and then people could do something like
    pg_dump --comment "generated on `date`"
if they want to have a timestamp.  I don't want a timestamp put
into the file by default, because that creates problems for
comparing dump files.

            regards, tom lane

pgsql-patches by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: Compiling libpq with VisualC
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] pg_dump --comment?