Re: BUG #17847: Unaligned memory access in ltree_gist - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #17847: Unaligned memory access in ltree_gist
Date
Msg-id 2654443.1681830401@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #17847: Unaligned memory access in ltree_gist  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: BUG #17847: Unaligned memory access in ltree_gist
List pgsql-bugs
Alexander Korotkov <aekorotkov@gmail.com> writes:
> LGMT.  I'm going to push v3 unless there are more comments.

I think this reads pretty awkwardly:

+ERROR:  siglen value must be integer-aligned
+DETAIL:  Valid are int-aligned values between "4" and "2024".

The DETAIL message's grammar seems a bit off.  Also, this is confusing the
range limitation with the alignment requirement.  How about just saying

ERROR:  siglen value must be a multiple of 4

and leaving out-of-range cases to be handled by the existing check?

            regards, tom lane



pgsql-bugs by date:

Previous
From: Noah Misch
Date:
Subject: Re: BUG #17901: Unexpected 'permission denied' error depending on which template used to create database
Next
From: Pavel Borisov
Date:
Subject: Re: BUG #17847: Unaligned memory access in ltree_gist