Re: posix_fadvise versus old kernels - Mailing list pgsql-hackers

From Tom Lane
Subject Re: posix_fadvise versus old kernels
Date
Msg-id 26472.1151434272@sss.pgh.pa.us
Whole thread Raw
In response to Re: posix_fadvise versus old kernels  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> While we could possibly come up with a suitable configure test to
>> determine whether posix_fadvise is actually safe to use on a given
>> system, I think we should seriously consider just reverting the patch.
>> As far as I saw, zero evidence was given that it actually does anything
>> measurable.  Without a benchmark to prove that it's worth spending more
>> time on, I'm disinclined to trouble over it.

> Agreed.  How about if we just #ifdef NOT_USED the code and mention the
> problem in a comment.

Works for me; I'll write something and commit it.  We can leave the
is-posix_fadvise-declared configure test in place, at least for now ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Mark Woodward"
Date:
Subject: Re: SO_SNDBUF size is small on win32?
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: GIN index creation extremely slow ?