Martijn van Oosterhout <kleptog@svana.org> writes:
> Note, what coverity actually picked up was that in the latter case in
> _selectOutputSchema that the free will always execute because if
> AH->currSchema was NULL it would have died at the beginning of the
> function (line 2205). It's me who misinterpreted the fix. We should
> probably be adding checks to all the strdups and to line 2205 instead.
Ah, OK, so it wasn't doing this on the basis of a global determination
that currSchema couldn't be NULL. That makes more sense then. I agree
that line 2205 would be more consistent if it checked for null currSchema.
regards, tom lane
