Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
Date
Msg-id 26453.1208749941@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
List pgsql-committers
Andrew Dunstan <andrew@dunslane.net> writes:
>> Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a stopgap
>> measure to get the Windows buildfarm members working again.  I don't
>> know if it's worth exposing these as configurables, or exactly how to
>> do it in the MSVC build system ...

> see src/tools/msvc/Solution.pm

> The options are picked up from config.pl (which is the equivalent of
> configure invocation options) in the new() subroutine, and the config
> files are written accordingly in the GenerateFiles() subroutine.

> In general I'm in favor of keeping these as closely aligned as possible.

Go for it --- I'm not excited about adding stuff to platform-specific
code that I can't test.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix a couple of places in execMain that erroneously assumed that
Next
From: "Dave Page"
Date:
Subject: Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a