Re: some errors and/or bugs? - Mailing list pgsql-docs

From Tom Lane
Subject Re: some errors and/or bugs?
Date
Msg-id 2639.977187769@sss.pgh.pa.us
Whole thread Raw
In response to some errors and/or bugs?  ("He Weiping(Laser Henry)" <laser@zhengmai.com.cn>)
Responses Re: some errors and/or bugs?  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-docs
"He Weiping(Laser Henry)" <laser@zhengmai.com.cn> writes:
> laser_zh=# select round(42.5);
>  round
> -------
>     42
> (1 row)
>
> is it correct? I think result should be 43.

It's correct, if the underlying float arithmetic is IEEE-compliant.
Rounding for exact half-integral values is supposed to be "round to
nearest even".  So 42.5 goes to 42, but 43.5 goes to 44.

I notice our NUMERIC rounding code does not do that ... perhaps it
should.

Also, the numeric round() function is just plain broken:

regression=# select round(42.5::numeric);
ERROR:  Function 'numeric_round(numeric, int4)' does not exist
        Unable to identify a function that satisfies the given argument types
        You may need to add explicit typecasts
regression=# select round(42.5::numeric,0);
 round
-------
    43
(1 row)

Looks like a silly oversight in the pg_proc entry for round(numeric).

            regards, tom lane

pgsql-docs by date:

Previous
From: "He Weiping(Laser Henry)"
Date:
Subject: some errors and/or bugs?
Next
From: Ryan Kirkpatrick
Date:
Subject: Re: 7.1 features list