Re: Add absolute value to dict_int - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add absolute value to dict_int
Date
Msg-id 26339.1583857958@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add absolute value to dict_int  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> So all we really need to do is upgrade [de]serialize_deflist to be smarter
> about int and float nodes.  This is still a bit invasive because somebody
> decided to make deserialize_deflist serve two masters, and I don't feel
> like working through whether the prsheadline code would cope nicely with
> non-string output nodes.  So the first patch attached adds a flag argument
> to deserialize_deflist to tell it whether to force all the values to
> strings.

On closer inspection, it doesn't seem that changing the behavior for
prsheadline will make any difference.  The only extant code that
reads that result is prsd_headline which always uses defGetString,
and probably any third-party text search parsers would too.
So I've pushed this without the extra flag argument.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: improve transparency of bitmap-only heap scans
Next
From: Julien Rouhaud
Date:
Subject: Re: backend type in log_line_prefix?