Re: expression_tree_walker() and primitive node types - Mailing list pgsql-bugs

From Tom Lane
Subject Re: expression_tree_walker() and primitive node types
Date
Msg-id 26246.1192198997@sss.pgh.pa.us
Whole thread Raw
In response to expression_tree_walker() and primitive node types  (Neil Conway <neilc@samurai.com>)
List pgsql-bugs
Neil Conway <neilc@samurai.com> writes:
> I wouldn't call this behavior buggy, but I found it somewhat surprising.
> expression_tree_walker() assumes that the walker has already been
> invoked on the current node (the node that a given recursive call of
> expression_tree_walker() has been invoked on). Therefore, calling
> expression_tree_walker() on a primitive node type, such as a Var, is a
> no-op.

The documented usage method is to call the walker itself at the top
level of recursion.  The walker calls expression_tree_walker (after
doing its thing on the node); other code should not call
expression_tree_walker directly.

            regards, tom lane

pgsql-bugs by date:

Previous
From: "Heikki Linnakangas"
Date:
Subject: Re: BUG #3673: Untrusted perl language: ERROR: could not open relation 1663/16384/1259: No such file or directory
Next
From: Martin Pitt
Date:
Subject: libpq5 8.3 breaks 8.2 compatibility with encodings