Re: Set notice receiver before libpq connection startup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Set notice receiver before libpq connection startup
Date
Msg-id 2620a664-7b44-48b2-9aa8-5f0131702d9c@eisentraut.org
Whole thread
In response to Re: Set notice receiver before libpq connection startup  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On 23.05.26 01:56, Chao Li wrote:
> 
> 
>> On May 22, 2026, at 23:28, Fujii Masao <masao.fujii@gmail.com> wrote:
>>
>> On Fri, May 22, 2026 at 11:56 PM Chao Li <li.evan.chao@gmail.com> wrote:
>>> PFA v4, just removed conn NULL check.
>>
>> Thanks for updating the patch! I've pushed it.
>>
>> Regards,
>>
>> -- 
>> Fujii Masao
> 
> Thanks for pushing and still working hard during the PGConf.

The committed patch violates the .gitattributes whitespace rules:

git show --check 06a5c3cdef02

contrib/postgres_fdw/connection.c:651: indent with spaces.
+                                                   /* expand_dbname = 
*/ false);

It is unfortunate that pgindent produces this layout that contradicts 
the git configuration.  (The current formatting also doesn't look like 
what I would produce in an editor, so I think git is right here.)

Maybe we could reformat this slightly to avoid that?  (unless someone 
wants to try to fix pgindent)





pgsql-hackers by date:

Previous
From: Alexander Lakhin
Date:
Subject: Re: 035_standby_logical_decoding might fail due to FATAL message lost inside libpq
Next
From: Andres Freund
Date:
Subject: Re: Heads Up: cirrus-ci is shutting down June 1st