Re: pread() and pwrite() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pread() and pwrite()
Date
Msg-id 26123.1541601037@sss.pgh.pa.us
Whole thread Raw
In response to Re: pread() and pwrite()  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: pread() and pwrite()  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Re: pread() and pwrite()  (Jesper Pedersen <jesper.pedersen@redhat.com>)
List pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 11/7/18 7:26 AM, Jesper Pedersen wrote:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2018-11-07%2001%3A01%3A01

> And lousyjack, which uses a slightly different way of calling valgrind,
> and thus got past initdb, found a bunch more:
> <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-11-07%2001%3A33%3A01>

I'm confused by this.  Surely the pwrite-based code is writing exactly the
same data as before.  Do we have to conclude that valgrind is complaining
about passing uninitialized data to pwrite() when it did not complain
about exactly the same thing for write()?

[ looks ... ]  No, what we have to conclude is that the write-related
suppressions in src/tools/valgrind.supp need to be replaced or augmented
with pwrite-related ones.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: plruby: rb_iterate symbol clash with libruby.so
Next
From: Andrew Dunstan
Date:
Subject: Re: valgrind on initdb