Re: is_absolute_path incorrect on Windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: is_absolute_path incorrect on Windows
Date
Msg-id 26121.1296757951@sss.pgh.pa.us
Whole thread Raw
In response to Re: is_absolute_path incorrect on Windows  (Bruce Momjian <bruce@momjian.us>)
Responses Re: is_absolute_path incorrect on Windows  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> Bruce Momjian <bruce@momjian.us> writes:
>>> I have reviewed is_absolute_path() and have implemented
>>> path_is_relative_and_below_cwd() to cleanly handle cases like 'E:abc' on
>>> Win32;  patch attached.
>> 
>> This patch appears to remove some security-critical restrictions.
>> Why did you delete the path_contains_parent_reference calls?

> They are now in path_is_relative_and_below_cwd(),

... and thus not invoked in the absolute-path case.  This is a security
hole.

>  I don't see a general reason to prevent
> ".." in absolute paths, only relative ones.
load '/path/to/database/../../../path/to/anywhere'
        regards, tom lane


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: ALTER EXTENSION UPGRADE, v3
Next
From: Robert Haas
Date:
Subject: Re: ALTER EXTENSION UPGRADE, v3