Re: Adding REPACK [concurrently] - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Adding REPACK [concurrently]
Date
Msg-id 260901.1776696126@sss.pgh.pa.us
Whole thread
In response to Re: Adding REPACK [concurrently]  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Adding REPACK [concurrently]
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2026-Apr-20, Antonin Houska wrote:
>> Is this an attempt to disable REPACK (CONCURRENTLY)? That would require
>> wal_level=minimal (due to commit 67c20979ce). In which way does REPACK seem to
>> break test_plan_advice?

> No, quite the contrary.  That test normally runs with wal_level=minimal,
> which causes REPACK to complain that it cannot start logical
> decoding.

So what you're saying is that the core regression tests will now fail
with wal_level=minimal?  I don't see how that can possibly be
considered acceptable from a global standpoint; we might as well
remove wal_level=minimal, because it will never again get tested.

I think you need to move these tests out into some other test suite
(or make a new one).

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ayush Tiwari
Date:
Subject: Re: [PATCH] Reject ENCODING option for COPY TO FORMAT JSON
Next
From: Antonin Houska
Date:
Subject: Re: repack: fix a bug to reject deferrable primary key fallback for concurrent mode