Re: Regression tests fails to start on system without unix sockets. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Regression tests fails to start on system without unix sockets.
Date
Msg-id 26075.1056212435@sss.pgh.pa.us
Whole thread Raw
In response to Regression tests fails to start on system without unix sockets.  (Kurt Roeckx <Q@ping.be>)
Responses Re: Regression tests fails to start on system without unix  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Kurt Roeckx <Q@ping.be> writes:
> The regression tests will fail to start on a system that doesn't
> have, or wasn't compiled for, unix domain sockets.
> I see some options to fix this:
> - Always start with -i
> - Make the "unix_sockets" variable depend on
>   HAVE_UNIX_SOCKETS intead of listen the OSs.

The second way is the way it should have been done all along.

Probably the best fix is to add a command-line switch to pg_regress
to instruct it to use -i, and then have the makefile test
HAVE_UNIX_SOCKETS to decide whether to pass that switch.  This way,
hand invocation of the script could easily run the test both ways,
on machines where that's possible.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: Two weeks to feature freeze
Next
From: Tom Lane
Date:
Subject: Re: Two weeks to feature freeze