Re: Figured it out (psql and Gnu readline) - Mailing list pgsql-general

From Tom Lane
Subject Re: Figured it out (psql and Gnu readline)
Date
Msg-id 26067.963449458@sss.pgh.pa.us
Whole thread Raw
In response to Re: Figured it out (psql and Gnu readline)  (Erich <hh@cyberpass.net>)
Responses Re: Figured it out (psql and Gnu readline)
Re: Figured it out (psql and Gnu readline)
List pgsql-general
Erich <hh@cyberpass.net> writes:
>> configure is supposed to handle all that for you ... if it failed to
>> find the right location of libreadline and associated includes then
>> the question is why.  You sure you ran configure after installing
>> the include files?

> I just deleted my postgres tree, and then unpacked it again, and ran
> configure again.  libreadline.a and libhistory.a are in
> /usr/local/lib/.  readline.h and history.h are in
> /usr/local/include/readline/.

OK ... my setup has the same files in the same places ...

> I then ran ./configure.

> When I look at config.h, I can see that it failed to detect
> /usr/local/include/readline/history.h.  Also, I see that it did define
> HAVE_HISTORY_IN_READLINE 1 which is incorrect.  I would have to make
> the change by hand to the file.

Well, that's darn peculiar.  configure.in has a test for
readline/history.h, big as life:
    AC_CHECK_HEADERS(readline/history.h)
Does the config.log file show why it failed to find the include?

HAVE_HISTORY_IN_READLINE seems to get defined if libreadline.a contains
a "using_history" symbol:

AC_CHECK_LIB(readline, using_history, AC_DEFINE(HAVE_HISTORY_IN_READLINE),
    AC_CHECK_LIB(history,  main) )


On my setup, which is readline 4.0 if I'm checking the right files,
HAVE_HISTORY_IN_READLINE does get defined, and AFAICT libhistory.a
doesn't get linked, but I most certainly do get history support.

Which readline version are you using?  Maybe the GNU guys rearranged
which functions live in which library.  If so, we probably need
to be probing for a different symbol in libreadline to be compatible
across more libreadline versions ...

            regards, tom lane

pgsql-general by date:

Previous
From: Tom Lane
Date:
Subject: Re: Triggers with arguments
Next
From: Philip Warner
Date:
Subject: Re: RE: [HACKERS] pg_dump & blobs - editable dump?