Re: allow changing autovacuum_max_workers without restarting - Mailing list pgsql-hackers

From Imseih (AWS), Sami
Subject Re: allow changing autovacuum_max_workers without restarting
Date
Msg-id 25FBADC0-52E7-4DE6-B043-68E5F77D4CB1@amazon.com
Whole thread Raw
In response to Re: allow changing autovacuum_max_workers without restarting  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: allow changing autovacuum_max_workers without restarting
List pgsql-hackers
> IIRC using GUC hooks to handle dependencies like this is generally frowned
> upon because it tends to not work very well [0]. We could probably get it
> to work for this particular case, but IMHO we should still try to avoid
> this approach. 

Thanks for pointing this out. I agree, this could lead to false logs being
emitted.

> so it might not be crucial to emit a
> WARNING here.

As mentioned earlier in the thread, we can let the autovacuum launcher emit the 
log,  but it will need to be careful not flood the logs when this condition exists ( i.e.
log only the first time the condition is detected or log every once in a while )

The additional complexity is not worth it.

Regards,

Sami





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: In MacOS, psql reacts on SIGINT in a strange fashion (Linux is fine)
Next
From: "Wen Yi"
Date:
Subject: Re: Things I don't like about \du's "Attributes" column