Re: pgcrypto: fix memory leak in openssl.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: pgcrypto: fix memory leak in openssl.c
Date
Msg-id 25970.1140447947@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgcrypto: fix memory leak in openssl.c  ("Marko Kreen" <markokr@gmail.com>)
Responses Re: pgcrypto: fix memory leak in openssl.c  ("Marko Kreen" <markokr@gmail.com>)
List pgsql-patches
"Marko Kreen" <markokr@gmail.com> writes:
> On 2/18/06, Marko Kreen <markokr@gmail.com> wrote:
>> pgcrypto crypt()/md5 and hmac() leak memory when compiled against
>> OpenSSL as openssl.c digest ->reset will do two DigestInit calls
>> against a context.  This happened to work with OpenSSL 0.9.6
>> but not with 0.9.7+.

> Ugh, seems I read the old code slightly wrong.  The leak happens
> also with regular digest(), although it will leak only 1 context
> instance, not the 1000+ as the crypt-md5 does.

I'm confused --- does this mean that the patch you sent recently
needs further work?

            regards, tom lane

pgsql-patches by date:

Previous
From: "Marko Kreen"
Date:
Subject: Re: pgcrypto: fix memory leak in openssl.c
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] WIP: Create shell-types explicitly