Re: empty column name in error message - Mailing list pgsql-hackers

From Tom Lane
Subject Re: empty column name in error message
Date
Msg-id 25805.1576599698@sss.pgh.pa.us
Whole thread Raw
In response to empty column name in error message  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: empty column name in error message  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
Amit Langote <amitlangote09@gmail.com> writes:
> I wonder if it's worthwhile to fix the following not-so-friendly error message:

> create index on foo ((row(a)));
> ERROR:  column "" has pseudo-type record

Ugh.  That used to work more nicely:

regression=# create index fooi on foo ((row(a)));
ERROR:  column "pg_expression_1" has pseudo-type record

But that was back in 8.4 :-( ... 9.0 and up behave as you show.
I'm guessing we broke it when we rearranged the rules for naming
index expression columns.

> For example, the attached patch makes it this:

> create index on foo ((row(a)));
> ERROR:  column "row" has pseudo-type record

Haven't read the patch in any detail yet, but that seems like
an improvement.  And I guess we need a test case, or we'll
break it again :-(

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: client auth docs seem to have devolved
Next
From: Dave Cramer
Date:
Subject: Re: client auth docs seem to have devolved