Re: Removing useless \. at the end of copy in pgbench - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Removing useless \. at the end of copy in pgbench
Date
Msg-id 25801.1532742728@sss.pgh.pa.us
Whole thread Raw
In response to Removing useless \. at the end of copy in pgbench  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: Removing useless \. at the end of copy in pgbench  (Tatsuo Ishii <ishii@sraoss.co.jp>)
List pgsql-hackers
Tatsuo Ishii <ishii@sraoss.co.jp> writes:
> While populating pgbench_account table by using COPY FROM STDIN,
> pgbench sends out "\." at the end of the copy data. However this is
> only necessary in the version 2 of frontend/backend protocol (i.e. the
> version 3 protocol does not need it). I think we can safely remove the
> code to save a few CPU cycle since we only support back to PostgreSQL
> 9.3 and the version 3 protocol has been supported since 7.4.

What exactly is the benefit of breaking compatibility with old servers?
Saving a few cycles during initial table population seems like it could
not be of interest to anyone.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Removing useless \. at the end of copy in pgbench
Next
From: David Rowley
Date:
Subject: Re: Speeding up INSERTs and UPDATEs to partitioned tables