Re: psql \d+ and oid display - Mailing list pgsql-hackers

From Tom Lane
Subject Re: psql \d+ and oid display
Date
Msg-id 25794.1396032062@sss.pgh.pa.us
Whole thread Raw
In response to Re: psql \d+ and oid display  (Bruce Momjian <bruce@momjian.us>)
Responses Re: psql \d+ and oid display  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Re: psql \d+ and oid display  (Stephen Frost <sfrost@snowman.net>)
Re: psql \d+ and oid display  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Thu, Mar 27, 2014 at 02:54:26PM -0400, Stephen Frost wrote:
>> I believe Bruce was suggesting to show it when it is set to *not* the
>> default, which strikes me as perfectly reasonable.

> We seem to be split on the idea of having "Has OIDs" display only when
> the oid status of the table does not match the default_with_oids
> default.

FWIW, I think that having the display depend on what that GUC is set to
is a seriously *bad* idea.  It will mean that you don't actually know,
when looking at the output of \d, whether the table has OIDs or not.

I could get behind a proposal to suppress the line when there are not
OIDs, full stop; that is, we print either "Has OIDs: yes" or nothing.
But I think this patch just makes things even more surprising when
default_with_oids is turned on.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: psql \d+ and oid display
Next
From: Fabrízio de Royes Mello
Date:
Subject: Re: psql \d+ and oid display