Re: ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?) - Mailing list pgsql-patches

From Tom Lane
Subject Re: ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)
Date
Msg-id 2574.1209064422@sss.pgh.pa.us
Whole thread Raw
In response to ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)  ("Brendan Jurd" <direvus@gmail.com>)
List pgsql-patches
"Brendan Jurd" <direvus@gmail.com> writes:
> I realised that there's no reason for preparing a separate SetNotNull
> subcommand anymore, now that ATExecAddColumn takes care of enforcing
> the constraint, so I removed this special case.

This part seems to me to be code beautification, not a bug-fix, and
shouldn't be back-patched (particularly in view of the fact that we
haven't tested the change all that much --- there might be other
places depending on the old behavior).

Will take care of this.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Brendan Jurd"
Date:
Subject: ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)
Next
From: Tom Lane
Date:
Subject: Re: ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)