Re: Assertion failure in get_attstatsslot() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Assertion failure in get_attstatsslot()
Date
Msg-id 2570.1278716889@sss.pgh.pa.us
Whole thread Raw
In response to Re: Assertion failure in get_attstatsslot()  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Tom Lane's message of vie jul 09 12:16:42 -0400 2010:
>> If anybody feels really uncomfortable with that, we could add a
>> compensating "Assert(IsBinaryCoercible(ARR_ELEMTYPE(statarray),
>> atttype))" into get_attstatsslot().  Not sure if it's worth the cycles.

> Cycles spent only in assert-enabled builds?  Why not?

I decided not to do it, not so much because of any performance worries
as that I didn't want to make lsyscache.c depend on the parser.  Maybe
sometime we should rethink where the parse_coerce.c functionality lives.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Assertion failure in get_attstatsslot()
Next
From: Andres Freund
Date:
Subject: Re: Assertion failure in get_attstatsslot()