Re: [PATCHES] Index creation takes for ever - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Index creation takes for ever
Date
Msg-id 25685.1079541419@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Index creation takes for ever  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [PATCHES] Index creation takes for ever
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> Where was it posted anyway?

> Found it:

>     http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&selm=200312010450.hB14ovH16330%40candle.pha.pa.us&rnum=8

Thanks.  The original patch is much older than I thought --- I was
looking in the November/December part of the archives.

> Personally, because frequently accessed duplicates appear more forward
> in the duplicate index, I think the sorting is only valuable when
> creating a new index.

Yes, and that's what this does.  Looking back, the original discussion
got a little confused because the TODO item about "order duplicate index
entries by tid" got brought into the mix.  Actually this patch has
nothing to do with that, because it only acts during btree creation not
during index updates.

On inspection I have no problem with the patch, only with the comments ;-)
If you like I'll revise the comments and apply.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Fernando Nasser
Date:
Subject: Re: COPY formatting
Next
From: Josh Berkus
Date:
Subject: Re: Constraints & pg_dump