Re: Minor fix in lwlock.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: Minor fix in lwlock.c
Date
Msg-id 25640.1112932046@sss.pgh.pa.us
Whole thread Raw
In response to Minor fix in lwlock.c  ("Qingqing Zhou" <zhouqq@cs.toronto.edu>)
List pgsql-patches
"Qingqing Zhou" <zhouqq@cs.toronto.edu> writes:
> The chance that num_held_lwlocks is beyond MAX_SIMUL_LWLOCKS is similar to
> the chance that failed to grasp a spinlock in 1 minute, so they should be
> treated in the same way. This is mainly to prevent programming error (e.g.,
> forget to release the LWLocks).

Hmm ... yeah, it's not too hard to imagine a bug leading to trying to
grab content locks on more than 100 buffers, for example.  Patch
applied, although I reduced the severity from FATAL to ERROR.  I don't
see any reason to think we'd be unable to recover normally from such a
bug --- do you?

            regards, tom lane

pgsql-patches by date:

Previous
From: "Qingqing Zhou"
Date:
Subject: Minor fix in lwlock.c
Next
From: "Qingqing Zhou"
Date:
Subject: Re: Minor fix in lwlock.c