Re: [PATCH] XLogReadRecord returns pointer to currently read page - Mailing list pgsql-hackers

From Andrey Lepikhov
Subject Re: [PATCH] XLogReadRecord returns pointer to currently read page
Date
Msg-id 2553f2b0-0e39-eb0e-d382-6c0ed08ca8ae@postgrespro.ru
Whole thread Raw
In response to Re: [PATCH] XLogReadRecord returns pointer to currently read page  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: [PATCH] XLogReadRecord returns pointer to currently read page  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
On 23.10.2018 0:53, Heikki Linnakangas wrote:
> I'd expect the decompression to read from the on-disk buffer, and unpack 
> to readRecordBuf, I still don't see a need to copy the packed record to 
> readRecordBuf. If there is a need for that, though, the patch that 
> implements the packing or compression can add the memcpy() where it 
> needs it.

I agree with it. Eventually, placement of the WAL-record can be defined 
by comparison the record, readBuf and readRecordBuf pointers.
In attachment new version of the patch.

-- 
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: "Nagaura, Ryohei"
Date:
Subject: Timeout parameters
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: WAL archive (archive_mode = always) ?