Re: Fix to not check included columns in ANALYZE on indexes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix to not check included columns in ANALYZE on indexes
Date
Msg-id 25504.1530227916@sss.pgh.pa.us
Whole thread Raw
In response to Fix to not check included columns in ANALYZE on indexes  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: Fix to not check included columns in ANALYZE on indexes
Re: Fix to not check included columns in ANALYZE on indexes
Re: Fix to not check included columns in ANALYZE on indexes
List pgsql-hackers
Yugo Nagata <nagata@sraoss.co.jp> writes:
> I found that both key columns and included columns are checked when analyze
> is run on indexes. This is almost harmless because non-expression columns
> are not processed. However, this check is obviously unnecessary and we
> can fix this to not check included columns. If we decide to support expressions
> in included columns in future, this must be fixed eventually.

AFAICS, we'd just have to revert this patch later, so I don't see
much value in it.

Also, is it really true that we don't support included expression
columns now?  In what way would that not be a bug?

            regards, tom lane


pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: SQL/JSON: documentation
Next
From: "David G. Johnston"
Date:
Subject: Re: CREATE TABLE .. LIKE .. EXCLUDING documentation